Changed AdditionalSketchFilesCopier legacy command into new builder API function #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
approved these changes
Jul 23, 2019
| // SketchCopyAdditionalFiles copies the additional files for a sketch to the | ||
| // specified destination directory. | ||
| func SketchCopyAdditionalFiles(sketch *sketch.Sketch, destPath string) error { | ||
| if err := os.MkdirAll(destPath, os.FileMode(0755)); err != nil { |
There was a problem hiding this comment.
at some point we may think to replace those path strings with paths.Path objects that have a much cleaner API to handle file operations.
| // MergeSketchSources merges all the source files included in a sketch | ||
| func MergeSketchSources(sketch *sketch.Sketch) (int, string) { | ||
| // SketchMergeSources merges all the source files included in a sketch | ||
| func SketchMergeSources(sketch *sketch.Sketch) (int, string) { |
There was a problem hiding this comment.
I'm wondering if these functions (SketchMergeSources, SketchCopyAdditionalFiles, etc.) may become methods of sketch.Sketch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the ongoing refactoring of the
legacypackage.Also changed few functions names in the new API to match the convention
builder.Sketch*to better group parts of the API that operates on specific objects like a Sketch in this case (no need of a stricter design, it's just for readability).